From cf0751e7da6bb16d002398460fbd715dd21d6f65 Mon Sep 17 00:00:00 2001 From: Elly <ellyjones@chromium.org> Date: Wed, 14 Aug 2024 15:40:02 +0000 Subject: [PATCH] root: add CRYPTO_OWNERS Per discussion on chrome-security-leads@, this change centralizes ownership of cryptographic code in chromium within a single root-level file. Existing OWNERS files for crypto code are left in place (since they reflect expertise within specific directories) but //CRYPTO_OWNERS is added as a fallback owner to all of them. Bug: None Change-Id: I069f3c9085219f78504f533e84046aadb01fa11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5770906 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Elly FJ <ellyjones@chromium.org> Reviewed-by: Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/main@{#1341684} --- CRYPTO_OWNERS | 13 +++++++++++++ components/encrypted_messages/OWNERS | 2 ++ components/webcrypto/OWNERS | 2 ++ crypto/OWNERS | 2 ++ third_party/boringssl/OWNERS | 2 ++ 5 files changed, 21 insertions(+) create mode 100644 CRYPTO_OWNERS diff --git a/CRYPTO_OWNERS b/CRYPTO_OWNERS new file mode 100644 index 0000000000000..dccc699ff36dc --- /dev/null +++ b/CRYPTO_OWNERS @@ -0,0 +1,13 @@ +# People listed in this file are responsible for making decisions about +# cryptography use in Chromium. If you are adding new cryptographic code, or +# adding complex uses of existing cryptographic code, please consult one of +# these people. + +agl@chromium.org +bbe@chromium.org +davidben@chromium.org +ellyjones@chromium.org +estark@chromium.org +mattm@chromium.org +svaldez@chromium.org +tsepez@chromium.org diff --git a/components/encrypted_messages/OWNERS b/components/encrypted_messages/OWNERS index abc6202b65634..650b1176f194d 100644 --- a/components/encrypted_messages/OWNERS +++ b/components/encrypted_messages/OWNERS @@ -1 +1,3 @@ estark@chromium.org + +file://CRYPTO_OWNERS diff --git a/components/webcrypto/OWNERS b/components/webcrypto/OWNERS index b3e40f69a3696..84dae86739c58 100644 --- a/components/webcrypto/OWNERS +++ b/components/webcrypto/OWNERS @@ -1,3 +1,5 @@ davidben@chromium.org ellyjones@chromium.org tsepez@chromium.org + +file://CRYPTO_OWNERS diff --git a/crypto/OWNERS b/crypto/OWNERS index d9697bd1607e8..8b56ef09f64a6 100644 --- a/crypto/OWNERS +++ b/crypto/OWNERS @@ -2,3 +2,5 @@ set noparent agl@chromium.org davidben@chromium.org mattm@chromium.org + +file://CRYPTO_OWNERS diff --git a/third_party/boringssl/OWNERS b/third_party/boringssl/OWNERS index 20168f0181a98..6f2473e1c1f4a 100644 --- a/third_party/boringssl/OWNERS +++ b/third_party/boringssl/OWNERS @@ -2,3 +2,5 @@ agl@chromium.org bbe@chromium.org davidben@chromium.org svaldez@chromium.org + +file://CRYPTO_OWNERS