aa6c892ece
This reverts commit bc5265a20462e98ae8b82825ecdceba442ec7567. Reason for revert: baselines updated, should be OK for cast now. Original change's description: > Revert "Roll Android Lint from DGEQcQfbonqqmrtaK... to hwubetoXxz5wxh6e9..." > > This reverts commit 5e2b589c4fdf6a7e8e944fdeff7f128256cd56dd. > > Reason for revert: This breaks android builds https://ci.chromium.org/ui/p/chromium/builders/ci/android-cast-arm-rel/8805/overview > > Original change's description: > > Roll Android Lint from DGEQcQfbonqqmrtaK... to hwubetoXxz5wxh6e9... > > > > If this roll has caused a breakage, revert this CL and stop the roller > > using the controls here: > > https://autoroll.skia.org/r/lint-chromium > > Please CC clank-build-core@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human > > is aware of the problem. > > > > To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry > > > > To report a problem with the AutoRoller itself, please file a bug: > > https://issues.skia.org/issues/new?component=1389291&template=1850622 > > > > Documentation for the AutoRoller is here: > > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md > > > > Tbr: clank-library-failures@google.com > > Change-Id: Ife450975d19e1c03da0025b494a8cac0527a0b5e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406060 > > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > > Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1439112} > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I2fb643fe622d4e0b24657c8162177ef4fc8b7f5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406014 > Owners-Override: Taiyo Mizuhashi <taiyo@chromium.org> > Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1439135} Change-Id: Ie50fc75cf5c2638bc325d5a275f92fe7f07af497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409381 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: Martin Kong <martinkong@google.com> Cr-Commit-Position: refs/heads/main@{#1439754}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.ccso it lives alongside existing features - Add your new feature to the list of
kFeaturesincast_features.cc
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}