OnSizeConstraintsChanged() needs to be called whenever the minimum
size changes. SetCanResize() does this internally.
Bug: 402795394
Change-Id: Ifff3481647df1325351b5aac9330790ebe31850e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409379
Auto-Submit: Ian Wells <iwells@chromium.org>
Reviewed-by: Sana Akbani <sanaakbani@google.com>
Commit-Queue: Sana Akbani <sanaakbani@google.com>
Cr-Commit-Position: refs/heads/main@{#1439660}
This CL fixes a test that will break as a result of:
https://chromium-review.googlesource.com/c/catapult/+/6373645
I think the cause of the failure is that the Android OS makes a scan
of media files (video, image, audio files) when they are added to the
Android device, and add the new files to a database.
The previous unzipping mechanism did not trigger this scan for
whatever reason, but the new archive extraction mechanism did trigger
this scan, which caused the test to fail.
Bug: 397459590
Change-Id: I5c00f15ff2a3bd5ca373577b134a84c93a033855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409751
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Martin Kong <martinkong@google.com>
Cr-Commit-Position: refs/heads/main@{#1439657}
If a url pattern is configured in both SerialAskForUrls and
SerialBlockedForUrls, access to serial should be blocked.
This is a copy of CL 3613279 by cmfcmf. It turns out this test is
valid and verifies an invariant that should be true.
Also update the documentation to reflect that.
Bug: 40837247
Change-Id: I8736a6d4c84465842841b3e87b321a54d31e411d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6407660
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439655}
Remove unused method from gpu_service.mojom after
ClientGpuMemoryBufferManager was removed which was using this.
Future CLs will remove rest of the unused code from GpuServiceImpl.
Bug: 394997675
Change-Id: I7823e3b9d147f8745e918b076554faa08722a1a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406861
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439654}
Remove unused method CreateClientGpuMemoryBufferFactory from gpu.mojom
after ClientGpuMemoryBufferManager was removed.
Future CLs will continue to remove related code from GpuServiceImpl and
other parts.
Bug: 394997675
Change-Id: I54c8e70206fa2f40b50295480d3617579cbbb36c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406458
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439653}
This CL refactors the boolean pref kGlicCompletedFre into an enum with values from glic::prefs::FreStatus to determine whether the user has not started, completed, or left the FRE incomplete.
Bug: 406530075, 391417447
Change-Id: Ia04c6275609259de64f484f94a28e1a64f5672bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406194
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sana Akbani <sanaakbani@google.com>
Cr-Commit-Position: refs/heads/main@{#1439652}
`auto` with no qualifiers copies; none of these loops actually need a
copy though.
Bug: 406927307
Change-Id: I0795cbc28c1308424c85e99e602de44ce27c36bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408133
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439650}
An AX node should only be marked as "focusable" if it is mouse or
keyboard focusable.
In the case of a scroller with a focusable child, both IsMouseFocusable
and IsKeyboardFocusable will return false, meaning that element is not
focusable. SupportsFocus() will return true because it recognizes the
element as a scroller.
Change-Id: I9a44d9fbefbf825073577b3123463eac8a473e56
Bug: 401019764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6392015
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439649}
Remove ClientGpuMemoryBufferManager and glue code from viz:Gpu.
Future CLs will remove mojom and other GPU service side code.
Bug: 394997675
Change-Id: I9546b6a4d133cef7ae45e558aaa5b8d12ed72909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406457
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439648}
In order to keep cookies and authorization in line, we imitate the
existing bound_session_credentials implementation with the new
net/device_bound_sessions/ implementation.
Fixed: 405437918
Change-Id: Ifaa536bd47af239967219841269f7ffb349e8944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6384566
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439647}
"announcements that confirm some action was taken should be removed"
and this API is being deprecated/removed.
Bug: 376750397
Change-Id: If8e34b363d0f670bc06d0c047b591a164563b77f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406273
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439646}
This moves the segmentation platform code out of the desktop UI code and
into the platform agnostic parts of the UI code.
Bug: 402201005
Change-Id: Iecccc4f75a9d1ebf442a72946d002ea1c4c1d7e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399913
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439645}
This CL add histograms to output the state of the queue. The goal
of these metrics is to catch unwanted queue states.
Bug: b:395939713
Change-Id: I20ba6f5de7e53df53d042bb60d21740400fc4c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6299070
Reviewed-by: Abe Boujane <boujane@google.com>
Commit-Queue: Aashna Sheth <aashnas@google.com>
Cr-Commit-Position: refs/heads/main@{#1439644}
This CL changes clamping +inf/-inf to zero to use
`gfx::ClampFloatGeometry` because +inf/-inf should never becomes to
zero.
Bug: 401393578,403071968
Change-Id: I2a9dd4474e6dc9158b254ac6e62780af89b439f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6401053
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Jason Leo <cgqaq@chromium.org>
Auto-Submit: Jason Leo <cgqaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439643}
In this chance we are relaxing the `CHECK_GE(delta, 0)`, i.e. the down
time should always be <= the even time of input event. This failing in
some cases in field. For now we are relaxing the check to let the
sequence be handled by Browser. If there was an active touch sequence on
Viz, the sequence on Browser is dropped.
Bug: 401270990
Change-Id: I49a54b01c069f27bdb49cfd5bf5b77707a457488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400595
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Petr Cermak <petrcermak@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Cr-Commit-Position: refs/heads/main@{#1439639}
- Restores the last tab the user had selected upon reopening the Task
Manager.
Bug: b:405195715
Change-Id: If66a95a58609456492f54095f48d6fbf5a46fd35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406661
Reviewed-by: Zhengzheng Liu <zhzhliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Michael Wojcicka <mwoj@google.com>
Cr-Commit-Position: refs/heads/main@{#1439637}
The method had grown quite a lot since it was introduced initially. In
this change I have introduced states to the InputTransferHandlerAndroid
class which better track what the class is trying to do.
Bug: 401270990
Change-Id: Ie5754264897cd65306792ae88157cf73f999efba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400594
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Cr-Commit-Position: refs/heads/main@{#1439635}
Since the service now supports multiple sessions, a session disconnect
should only happen on a service crash, not because another session
started.
Change-Id: Idcc7be39e3a1ee982cc44045f986253b3999adcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405709
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439631}
This function moves Get{Year,Month,Day}Range() from
field_filling_entity_util.cc to a new file and adds tests.
Bug: 396325496
Change-Id: Id51c873b211e09a492f7c236f6a5c13f09b4c502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406897
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1439627}
This crash is happening in GetTreeFromId when tree_infos_ does not
contain the tree_id, which should not happen unless the tree
has recently been destroyed and AccessibilityLocationChangesReceived
is triggered immediately after.
The test was able to repro the crash stacktrace but this is difficult to
repro in a live build.
Bug: 405948702
Fixed: 376211390
Change-Id: I750fdd22854d641525b81124675e60bd716fa19c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409711
Reviewed-by: Kristi Saney <kristislee@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1439626}
context: These two are supported via the dataflow job. Now adding it to the new workflow
bug: b/318738818
Change-Id: I64e20ec82fecccf1afc7b70034fb4bf9b20d2f42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408277
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/main@{#1439625}
Produced via:
python3 tools/metrics/histograms/suffixes_to_variants.py \
--start=n --end=o
Note: Some suffixes aren't able to be handled by the script,
which are left untouched for now.
Manually undid changes to na_cl/histograms.xml, which had
errors.
Bug: 402455327
Change-Id: I968d176f9bc1fcc48ddbe27e3e8ed596f12a3463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409014
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439624}
The 50s duration on pseudo-renderiong-invalidation still permitted
drift in pixel values, presumably due to cross-fade brightening.
Replaced with a pause. The other tests were pausing on the group, but
animation-play-state is non-inheritted so animation in the image-pair,
old, and new were still running. These are all paused now.
Bug: 324915834, 343288729
Change-Id: I56b9f13e41121787faef21e19d204399f8a2bc2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409153
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439621}
This CL moves properties to ivars in AddPasswordViewController.
Indeed, according to best practices, using ivars is better than private
properties where they simply act as a wrapper around plain ivars.
Fixed: 402199280
Change-Id: Ibdd6b7bb0cf542ae7160edf479b060f84da6058b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399175
Commit-Queue: Prasanaa Vingadassamy <prasanaa@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Adam Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/main@{#1439617}
