- Explicitly expect that Tabs & Extensions have kNoSubType.
- Implicitly expect that Browser/System renderers are not regular
renderers.
- Only include PLUGINS in Tabs & Extensions, not both Tabs & Extensions
and Browser/System.
- Include NACL in Browser/System processes for completeness.
Bug: b:407103151
Change-Id: I35d6ac180da09651edc5dc20502fc9e846cb21f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410671
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Michael Wojcicka <mwoj@google.com>
Cr-Commit-Position: refs/heads/main@{#1439764}
This CL implements basic painting for Gap Decorations in flex.
In order to implement the rules, we had to add some data to the
`GapIntersections` as well as the `GapGeometry`. For flex, we use
`is_blocked_before_/after` to indicate whether the intersection borders
the edge of the container (is blocked by the edge).
This CL adds the `ContainerType` enum, and adds a member of this type to
`GapGeometry` which dictates for what type of container that
`GapGeometry` object is (i.e. flex).
We also add `inline_gap_size_`. In flex it refers to the gap between
flex items, and in grid it refers to the column gutter size.
For `block_gap_size_` in flex, it refers to the gap between flex lines
and in grid it refers to the row gutter size.
Bug: 357648037
Change-Id: Ifc65ba53049bff52388f57afda2471e3dce6adb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367772
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1439763}
This reverts commit ed61d16b713ba10434f19a8d38e656f9fdd9a060.
Reason for revert: Looks like the memory sanitation bot isn't happy with what you're doing with the string in InitMockSegmentationPlatformService. First failure can be seen here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/54888/overview
Original change's description:
> [FedCM] Move segmentation platform service to IdentityDialogController
>
> This moves the segmentation platform code out of the desktop UI code and
> into the platform agnostic parts of the UI code.
>
> Bug: 402201005
> Change-Id: Iecccc4f75a9d1ebf442a72946d002ea1c4c1d7e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399913
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Zachary Tan <tanzachary@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1439645}
Bug: 402201005
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Id0b7043841f3402d06f6bfffd1d113acd8f7c3d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410894
Owners-Override: Tim Judkins <tjudkins@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tim <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439759}
Previously added functionality but waited for crrev.com/c/6289226
to land before integrating. This CL integrates:
- Tap on card (open URL)
- 'See more' (open price tracking menu)
- Long press -> hide card
Video: https://drive.google.com/file/d/1kbaeIl2XgZI4nXOXhWmWWSGbak0oF1fu/view?usp=sharing
Bug: 392973346, 404335870, 392972945
Change-Id: I943066e7196a4b0d662a1d1d212f2d34e3180d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408935
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439758}
We used "saved group" as the name of the coral desk templates. The cl
uses the coral chip's title as the template name such that if the group
title is in generation, the template will use the default
"Suggested group" as its name, and use the real group name otherwise.
Test: manual, unit tests
Bug: b:407064152
Change-Id: Iaa3a0efce831870a4fb1953a5db5ab41ef54d9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408136
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439757}
Even if they have a set type, server predictions for NO_SERVER_DATA
without a specified prediction source should be replaced when a new
server prediction is added.
Bug: 404463608
Change-Id: Ifec3da2db97c22c1314121326e0705a67b44263b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408772
Commit-Queue: Jan Keitel <jkeitel@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1439756}
This reverts commit bc5265a20462e98ae8b82825ecdceba442ec7567.
Reason for revert: baselines updated, should be OK for cast now.
Original change's description:
> Revert "Roll Android Lint from DGEQcQfbonqqmrtaK... to hwubetoXxz5wxh6e9..."
>
> This reverts commit 5e2b589c4fdf6a7e8e944fdeff7f128256cd56dd.
>
> Reason for revert: This breaks android builds https://ci.chromium.org/ui/p/chromium/builders/ci/android-cast-arm-rel/8805/overview
>
> Original change's description:
> > Roll Android Lint from DGEQcQfbonqqmrtaK... to hwubetoXxz5wxh6e9...
> >
> > If this roll has caused a breakage, revert this CL and stop the roller
> > using the controls here:
> > https://autoroll.skia.org/r/lint-chromium
> > Please CC clank-build-core@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
> > is aware of the problem.
> >
> > To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
> >
> > To report a problem with the AutoRoller itself, please file a bug:
> > https://issues.skia.org/issues/new?component=1389291&template=1850622
> >
> > Documentation for the AutoRoller is here:
> > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
> >
> > Tbr: clank-library-failures@google.com
> > Change-Id: Ife450975d19e1c03da0025b494a8cac0527a0b5e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406060
> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> > Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/main@{#1439112}
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I2fb643fe622d4e0b24657c8162177ef4fc8b7f5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406014
> Owners-Override: Taiyo Mizuhashi <taiyo@chromium.org>
> Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1439135}
Change-Id: Ie50fc75cf5c2638bc325d5a275f92fe7f07af497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409381
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Martin Kong <martinkong@google.com>
Cr-Commit-Position: refs/heads/main@{#1439754}
Mark all strings as translatable and add sha file.
Bug: b:403314540
Change-Id: Id26a273914752ac70852c0f821f3abaa807ed9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410731
Commit-Queue: Vincent Chiang <vincentchiang@chromium.org>
Reviewed-by: Michael Wojcicka <mwoj@google.com>
Cr-Commit-Position: refs/heads/main@{#1439753}
https://crrev.com/c/6361483 made it so that GraphiteCacheController
waited for all instances to be idle before doing idle cleanup. This was
primarily aimed at Android+DrDC where there are two GPU threads and we
want them both to go idle before doing most of the cleanup. The viz
thread also has a GraphiteCacheController and it calls ScheduleCleanup()
from SwapBuffers(). This is different from Ganesh where SwapBuffers()
had no impact on if GrCacheController was considered idle.
Use a local idle in in viz thread GraphiteCacheController so that it
doesn't impact GPU thread controllers. For non-DrDC this reverts back to
the how it worked before as there is only a single GPU thread using the
global idle id.
Bug: 398193014
Change-Id: I0e443111362ec6963188028f0190c6d83f3e5432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409155
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439752}
This rename allows deduping the initialization logic used by Cast
Service in a standalone APK build.
Bug: b:341792617
Test: Ran in split and standalone way on a device
Change-Id: I0713d01c5ac9e5d686d39f3f5711c5008f9bf414
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409771
Commit-Queue: Vigen Issahhanjan <vigeni@google.com>
Reviewed-by: Shawn Quereshi <shawnq@google.com>
Cr-Commit-Position: refs/heads/main@{#1439751}
This exports the cast_browser code, including Java, C++ and resources,
in a form that can be merged into an apk containing the non-chromium
parts of Google Cast.
Fixes: 399749434
Bug: 341792617
Test: build downstream mediashell target against imported dist_aar
Change-Id: I9237ceee082b50631ed5cca8db3215d3e88e6bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6350478
Commit-Queue: Vigen Issahhanjan <vigeni@google.com>
Reviewed-by: Shawn Quereshi <shawnq@google.com>
Reviewed-by: Vigen Issahhanjan <vigeni@google.com>
Cr-Commit-Position: refs/heads/main@{#1439750}
Refactor the service to use callback to make it easier to add additional
async checks in the availability.
Change-Id: I3a96096839e63d2f5963b6b545e52944e494fbf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6407273
Reviewed-by: Salvador Guerrero Ramos <salg@google.com>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439748}
OBSOLETE_HISTOGRAM[Android.ExplicitViewIntentFinishedNewTabbedActivity]=Histogram was added as part of investigations but this is no longer needed as the implementation guarded by the above flag has been active for some time now.
Bug: 397217627
Change-Id: I22bea9395d906d79b1a654d48fe4a39b76dc66f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410111
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439747}
Adds support for the kPrivateAggregationApiErrorReporting feature*,
including the new flow involving two calls to the interface: first,
`InspectBudgetAndLock()`; and then, `ConsumeBudget()`. The old flow
(when the feature is disabled) is also maintained for now.
When the feature is disabled (which it is by default), this cl should
have no effect. These new calls are also not yet integrated with the
manager; this will be done in a follow-up cl.
*This feature is described further here:
https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/error_reporting.md
It was specified here:
https://github.com/patcg-individual-drafts/private-aggregation-api/pull/172
Bug: 381788013
Change-Id: Iccd452826b887e1de39a33ab5344de2de6774978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304832
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439738}
String resource used was added in https://crrev.com/c/6389020
Bug: 393162528
Change-Id: Iad3dec12eb00a7ea9bc2418ae371d32ea025a59c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409452
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: Nick Birnie <birnie@google.com>
Reviewed-by: Andrea Gomez <andreaxg@google.com>
Cr-Commit-Position: refs/heads/main@{#1439736}
PdfOopif feature when disabled opens PDFs in a guestview and an
associated tab target. This wasn't getting filtered from top level views
determination. This CL expands the filter to chrome-extension prefix to
mitigate. Also adds associated regression tests for PdfOopif disabled
state as well as Mv3 chrome extension that creates tabs.
Bug: 396611138
Change-Id: Ibaf1df4696d86d982a52dd24535233d24e34187e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6383500
Commit-Queue: Alex N. Jose <alexnj@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439735}
Add methods to set and manage text annotations to the Ink2Manager.
Add a test suite for the class for both existing code and the new
additions.
Note that since backend/frontend communication is still TBD for text
annotations, the manager currently just logs to console.info, instead
of notifying the plugin about changes to text properties.
Bug: 402547554
Change-Id: I1ae7e833a4cf0c167b6afac50c28bdb77ed4bad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394083
Reviewed-by: Andy Phan <andyphan@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439733}
Define the network traffic annotation for the Lens Web API POST request.
Bug: 399425007
Change-Id: I626b695607deb58f9cbe684838b90e277b7b4400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406775
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Elijah Hewer <hewer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439731}
This CL:
* Modifies the existing TestNetLogManager so that it can be used
outside net_unittests.
* Uses LOG(ERROR) instead of VLOG(1) since passing both
`--log-net-log` and `--vmodule='test_net_log_manager=1' flags was
redundant.
* Adds ForceStart() method so that TestNetLogManager can dump
NetLog events without `--log-net-log` flag.
* Adds TestNetLogManager instance to NetworkServiceTestWithService
After this CL, tests in NetworkServiceTestWithService can call
ForceNetLog() to dump NetLog events for debugging.
Bug: 336167322
Change-Id: Iecde02092675418a2bc0ae21a4590f176e43ad77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399235
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439729}
We mistakenly detected NVDA as being Narrator. This CL fixes it.
Change-Id: I34307ce224ff21ef72b15fb83e3e2f997adeec8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410172
Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1439728}
This option was introduced to eliminate a race condition in tab dragging
interactive_ui_tests for Lacros. Lacros is no longer, so this complexity
can be eliminated.
This is a pure revert of the code portion of this previous CL:
https://crrev.com/c/5179586
Bug: 354842935
Change-Id: If5e4b5fd6be0040a2398310ef9a598610d9d5abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409976
Commit-Queue: Alex Yang <aycyang@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439727}
This parameter is part of the
`FledgeLimitSelectableBuyerAndSellerReportingIdsFetchedFromKAnon`
feature, which enables the browser to limit the number of
`selectableBuyerAndSellerReportingIds` for which k-anonymity is fetched.
This new parameter helps reduce any potential confusion over which of
the `selectableBuyerAndSellerReportingIds` can be part of a bid that
could potentially be considered k-anonymous by only allowing those
limited set of `selectableBuyerAndSellerReportingIds` to be provided to
calls to `generateBid()`, but only loading the limited set of
`selectableBuyerAndSellerReportingIds`.
Change-Id: I44ca4c0a489bef6f130ef102f2e8efb1681b852f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410131
Reviewed-by: Russ Hamilton <behamilton@google.com>
Commit-Queue: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1439726}
Add tests that check the default zoom level for the PDF extension host.
This is a follow-up for https://crrev.com/1432129.
Bug: 372932834
Change-Id: I67fd0de53fc8727e1e52ce83c876089de75dc591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6358260
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439722}
This change updates the OnTaskPodController implementation to surface
the OnTask pod when the SWA window is reactivated. The widget gets
hidden by default when the window is hidden.
Bug: b:406556286,b:405481370
Change-Id: Iae71dd14a14c0673725450f739ecb2d97232da6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409053
Reviewed-by: Luke Cao <caott@google.com>
Commit-Queue: Vignesh Shenvi <vshenvi@google.com>
Cr-Commit-Position: refs/heads/main@{#1439719}
The migrated "Linux" functions seem to actually support both ChromeOS and Linux previously, and the migration for OsSignalsCollector only created the new util functions for Linux.
Making platform gating more accurate to prevent any issue for EV on ChromeOS
Change-Id: I9b878846413d817b1d687454ad46aaea08ffcb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405454
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Zonghan Xu <xzonghan@chromium.org>
Auto-Submit: Zonghan Xu <xzonghan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439718}
When scheduling a form submission in a separate task,
CDP client cannot figure out whether some action has caused
a form submission navigation.
This change emits an additional Page.frameRequestedNavigation
event synchronously for the form submission.
Bug: 350540984
Change-Id: Ibb1c1874479a5e06261ab9e89e31958d52e425d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396171
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439717}
Replace uses of base::wcstring_view with const std::wstring& because
app_user_model_id wasn't getting passed correctly.
Will investigate later, but would like this before m136 branches.
Bug: 343734031
Change-Id: Ia87f70d63de3dbd31c182ca23bda4938b5d4d87b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410311
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/main@{#1439716}
