This metric is a count of the primary K12 users' age classification
(under 18 or above/equal 18).
NO_IFTTT=will add it in a separate cl.
Bug: 404618021
Change-Id: I0b1336f0fcbb12ab96a0ea1b8e8d08a0758c3e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398264
Commit-Queue: Vignesh Shenvi <vshenvi@google.com>
Reviewed-by: Vignesh Shenvi <vshenvi@google.com>
Reviewed-by: Luke Cao <caott@google.com>
Commit-Queue: Zifan Zhang <zifanzhang@google.com>
Cr-Commit-Position: refs/heads/main@{#1439713}
46e74bcb6...24676764a
Using wpt-import in Chromium 0b5d5952ece45a57e9de50c43df0c089492554a7.
With Chromium commits locally applied on WPT:
de299b3916 "[Language Detector] Implement *CreateCoreOptions, [...]
Note to gardeners: This CL imports external tests and adds expectations
for those tests; if this CL is large and causes a few new failures,
please fix the failures by adding new lines to TestExpectations rather
than reverting. See:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
jsbell@chromium.org:
external/wpt/resources
meade@chromium.org:
external/wpt/web-animations
NOAUTOREVERT=true
R=rubber-stamper@appspot.gserviceaccount.com
No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: I7e835a847014d1884394fdd02315f13a9224c79f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408393
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1439712}
Previous only supported one display. Made changes to support multi
display by changing the root and destroying the ax widget as needed.
Added some code to avoid updating the a11y tree when the root is
shutting down, otherwise there would be a post task and a crash.
Test: manual
Bug: 401066100
Change-Id: I5004f8d4ee977af4ac39ae84c96a08bd2e5034c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6402653
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Elijah Hewer <hewer@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439711}
Previously, the DictationButtonTray icon would repaint for every text
field change when a user typed into a text field with dictation enabled.
This repaint was triggered by updating the icon image in `UpdateIcon()`.
This CL fixes the repaint issue by only updating the icon image if
`GetIconImage()` returns a new image based on the updated state of
DictationButtonTray.
Bug: b:402804568
Change-Id: I4a0f1234401bad1447f9d310ef1db7c4a1bf3a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405591
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Auto-Submit: Zoraiz Naeem <zoraiznaeem@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439710}
This CL adds update_token as a field in the web_app to be stored in the
web_app_database.
This contributes to implementing a token-based update for predictable
web app updating. Design doc:
https://bit.ly/predictable-webapp-updating-prd
Bug: 403252576
Change-Id: I306eca0dbaf3206ff765393b70463e6058e25937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6397152
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Commit-Queue: May Siem <msiem@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439709}
The new value SCAM_EXPERIMENT_CATCH_ALL_ENFORCEMENT will be used when
there's a scam campaign that's largely spread and we are able to track
down enforcement through pre-existing triggers. If such enforcement is
not needed but used for telemetry only, the verdict should resort to
SCAM_EXPERIMENT_CATCH_ALL instead.
Server update: cl/741258575
Bug: 406818099
Change-Id: I6c6fcce34f381bab02f19c99c03ae8fbca7e38c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405354
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Seung Jae Lim <andysjlim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439707}
We already know this is not true in some cases, due to Android platform
bug(b/395610162), where we see the downtime is different for some of the
touch moves. We see the CHECK failing in field which means this must be
true for some other cases as well. For now we can relax the check until
the platform side bugs are identified and fixed.
Bug: 401233890
Change-Id: I810e940bc7d2208a182a871c109f0ba3e7718ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403095
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Kartar Singh <kartarsingh@google.com>
Reviewed-by: Petr Cermak <petrcermak@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439706}
This CL adds a utility function to validate the user and create a
passkey, as this step will be postponed in a completion block when
presenting a confirmation dialog before creating a passkey.
Bug: 382479915
Change-Id: I6d6c0ebb3ca8f7eb21e5a39cd7eae74f68d43877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408371
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439703}
There are two definitions of the UUID with the same value. Default to
always using the common file.
Bug: <none>
Change-Id: Id3f2fea06ddc734cbe2dc684a976e8f1a8ca055b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409154
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Vikram Pasupathy <vpasupathy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439700}
This is used for some themes and also the overline on tab groups
Bug: 403351027
Change-Id: I7fa5c07bad9ab124e428220d6007b555937a2bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6391735
Reviewed-by: Emily Shack <emshack@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439697}
Dependencies on NativeMessagePort are creating multiple dependency
cycles between //chrome/extensions/browser and other areas. This CL is
the first step in breaking the cycles by moving NativeMessagePort to
//extensions/browser/api/messaging.
This CL removes the `Core` inner class that is causing coupling between
NativeMessagePort and the NativeMessageHost implementation. Instead, an
abstract base class called `Dispatcher` can be derived from to provide
this functionality. The next CL will move the dispatcher to its own
source file and move NativeMessagePort.
Bug: 40593486
Change-Id: I47a6cf8f1b68aabb6b5f031270920f7be7c25a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405138
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Solomon Kinard <solomonkinard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439696}
Instead of reporting an error and stopping playback, now we simply drop
packets if they fail bitstream conversion. It protects accelerated
decoder, but also preserves a lot of tolerance to slightly corrupted
videos.
We drop packets for a lot of reasons, it's okay to add another one.
This CL also reverts http://crrev.com/1434331 because its approach
turned out to be not effective.
Bug: 403414998, 404090745, 406162257, 393652851
Test: playing videos from the bugs above
Change-Id: I9cdf0799f43e0b6cb65359fbfbaf9baeb20581e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408020
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439692}
Adds metrics for saving generated strong password from add password
menu.
Only password that matches the generated password are added as
generated.
If the password is typed manually by the user or generated
by the suggest strong password and was modified afterward,
it does not count as generated.
Fixed: 401003679
Change-Id: Ia70912d4e36acd7d7805f0f3ac023c0fe2a7b4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333976
Reviewed-by: Adam Arcaro <adamta@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Prasanaa Vingadassamy <prasanaa@google.com>
Cr-Commit-Position: refs/heads/main@{#1439689}
One-line change to ease revert if some untestable downstream build
breaks with an `error: ... is unsafe` warning.
Bug: 390223051
Change-Id: I5852938e12745d8f859d207d55f679f8e56ab137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393815
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Mega-CQ: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439688}
This CL adds user action metrics for when BB is disabled or enabled by
toggling from glic settings. This is done by replacing the existing
`Glic.OsEntrypoint.Settings.Toggle` histogram with two user actions,
`Glic.OsEntrypoint.Settings.ToggleEnabled` and
`Glic.OsEntrypoint.Settings.ToggleDisabled`.
Bug: 391417447,406788386
Change-Id: Ic1dd1d8dfb148fd2c54e49c9e8de4473a71e479b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403533
Commit-Queue: Ananya Seelam <ananyaseelam@google.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439687}
This adds test coverage for the changes introduced in
https://crrev.com/c/6079577 and https://crrev.com/c/6373548.
Bug: 379030052
Change-Id: I45996ac1aff72caa2a8c36eee96e19f30462ea87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409854
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Sandor «Alex» Major <sandormajor@chromium.org>
Commit-Queue: Sandor «Alex» Major <sandormajor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439684}
This change adds the remaining missing strings required for the Reminder
Notifications project. These strings are used across the feature's user
interface, including permission alerts, confirmation/undo snackbars,
swipe actions, In-Product Help (IPH) bubbles, and text within the iOS
notification settings screen.
Fixed: 407065279
Change-Id: Ie6b0fa7323f7bfbded12bf737c26d8db822b7c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408533
Reviewed-by: Ernesto Izquierdo Clua <eic@google.com>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Auto-Submit: Benjamin Williams <bwwilliams@google.com>
Reviewed-by: Hira Mahmood <hiramahmood@google.com>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439683}
In the process of trying to update the soundscape playlists to have
localized translations, we realized that the new config size will exceed
our previous expectations. This CL updates the max config size allowed,
updates the config endpoint for backwards compatibility, and also adds
some tests for other translation cases.
Bug: 360422919
Test: updated, added new RTL test
Change-Id: I4a293f8235e3bf54fdb511df327700d9dde0b756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400293
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Richard Chui <richui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439679}
Some were disabled in https://crrev.com/c/6394811 and one was disabled
in https://crrev.com/c/6373789.
FocusedTabChange is still disabled because of the
temporarily-nothing-in-focus bug.
Bug: 406528268, 406843285
Change-Id: Ib2bf442f013b425f38e5ea4869a92aac417fc3e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409891
Reviewed-by: Baran Erfani <baranerf@google.com>
Commit-Queue: William Liu <liuwilliam@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439677}
* Disable paint holding
* Use for test function for resizing
* Force device scale factor to 1.f
* Add an extra rAF to initial capture (the part that seems to fail
correct capture)
R=kevers@chromium.org
Bug: 400187507
Change-Id: Icc05a16168f0e6a09d838063add46a3a3167b1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409851
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439673}
When starting a drag from a renderer, the browser process filters out
URLs that the initiating renderer process should not be able to navigate
to, e.g. a random http/https page should not be able to specify
chrome://settings/ as URL to navigate to when dropped.
However, when dropping, Chrome is clever and tries to interpret text as
URLs when needed. To prevent this from bypassing the URL filtering, only
allow this conversion if:
- the drag data does not originate from the renderer
- or the text to URL conversion results in a HTTP or HTTPS url
Bug: 404000989
Change-Id: I28baf7e6385b440af7e76b08471588299e24e247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400553
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439671}
ExtensionsApiClient has some virtual functions controlled by this flag.
Unfortunately, the derived classes implement overrides and these
declarations and definitions aren't controlled by this flag, which leads
to compilation errors.
This CL adds the necessary ifdef blocks.
Bug: 356671305
Change-Id: I285e6dd8fdb9a56a79db4c22deb68f6c55e7c750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394592
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439669}
