Fallout from earlier tree-wide attempt to enable these warnings.
Bug: 390223051
Cq-Include-Trybots: luci.chromium.try:linux-v4l2-codec-rel
Change-Id: I0a3f9d04c39367f03f5fd090e678f71cd12abcc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410313
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439815}
OpenH264 can resize frames automatically only if
- the input and output aspect ratios are the same and
- the input is larger than the output in both dimensions.
This CL does manual scaling when these conditions are not met.
Bug: 404887295
Change-Id: I9ba4fb55231abc157b359108673d62a558b8babf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410892
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439813}
This feature was designed for a couple specific PKI enforcement
actions and hasn't been used in several years.
Bug: 406821209
Change-Id: Ib165b2374e7ea293df3e19d47c3c729fa4a6d601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406459
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439812}
Tie the active state on the sparkle-placeholder directly to the
`thumbnailsLoading_` value.
For an image that was never returned because it was filtered out,
`isTileVisible` would return false, and the active state would be true.
This caused the `render` function on the sparkles to keep firing.
BUG=b:406321809
TEST=manual
Change-Id: Ib5eee802f10dde4fa7046033a45184cd6bf2587f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410279
Auto-Submit: Erica Lee <ericamlee@google.com>
Reviewed-by: Jason Thai <jasontt@chromium.org>
Commit-Queue: Jason Thai <jasontt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439807}
This CL allows the "Ask your parent" interstitial to adjust to iOS system text size. "Zoom text..." from 3-dot menu will still work on
top of this.
Based on components/security_interstitials/.../interstitial_large.html
Bug: 405993406
Change-Id: I26c3e0135428fa38b8b692484198252ff97f7eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395058
Commit-Queue: Duong Dac <ddac@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439803}
Currently it stores the rotation controlled by accelerometer, which
is plain wrong. This will result in locking to he wrong orientation
when restarted.
Bug: 391763863
Test: covered by unit test. Confirmed that test fails w/o fix.
Change-Id: Ia4487e7f1e4f50746009d893517b321d5f97d0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400873
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Vincent Chiang <vincentchiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439799}
Leaving is sometime performed within ShareKit UI in manage screen.
Bug: 403330842
Change-Id: Icad7f9609e4a3086463c0e6fda9f3da8e0577914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395165
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439796}
This CL fixes a crash that would happen if an AudioContext is closed
while the promise returned by AudioContext::setSinkId is still
resolving.
The crash happens because the Garbage Collector (GC) does not
immediately invalidate all the elements of
AudioContext::set_sink_id_resolvers_ after the clear call in
AudioContext::DidClose. Because of it, a task posted during
SetSinkIdResolver::Start to execute
SetSinkIdResolver::OnSetSinkIdComplete still executes. At this point,
however, the AudioContext is already closed and the objects in
AudioContext::set_sink_id_resolvers_ should be considered invalid.
The fix consists in manually invalidating the
SetSinkIdResolver::Member<ScriptPromiseResolver> when the AudioContext
is closed. This CL also makes changes to how media::OutputDeviceStatus
enums are handled to conform with the best practices of
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/styleguide/c++/checks.md#examples
Bug: 381126158, 40580068
Change-Id: Ie8f447c095ebd8333a6e2e1a6f5581b3b00d2d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406063
Commit-Queue: Gabriel Brito <gabrielbrito@microsoft.com>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Auto-Submit: Gabriel Brito <gabrielbrito@microsoft.com>
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439793}
Per AMD this should be fixed in: (Adrenalin 23.11.1,
Driver Version 23.20.23.01 for Windows® 10 and
Windows® 11 (Windows Driver Store Version 31.0.22023.1014).
Fixed: 40738684
Change-Id: Id509231d0fdce61703ee8c481dbc298530231bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387851
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439791}
Before this CL, if users open tab B and C from parent tab A, only B
and C will be included in one suggestion; after this CL, A, B and C
will be included in the same suggestion.
Bug: 397221723
Change-Id: I45fff71c901c7f0d045184ff2aa0e1ce6f82a623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408193
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439790}
This simplifies callsites from:
resolver->Resolve(V8EnumClass(V8EnumClass::Enum::kEnumValue));
to:
resolver->Resolve(V8EnumClass::Enum::kEnumValue);
Use this pattern in gamepad_haptic_actuator.cc as a demonstration
Change-Id: Id1dd886611c611343104d1f5ba0463a103630521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410845
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439786}
Adjust the positioning logic to avoid the capture label and action
button container overlapping in some edge cases:
1. Currently, the capture label avoids the action button container
bounds, but not the other way round. Make the action button container
also avoid the capture label to help avoid overlap regardless of
which bounds are set first.
2. Don't try to avoid the action container bounds if it is invisible
(otherwise, the capture label can move around unexpectedly).
3. Make the capture label prefer falling back to "above" the region
rather than "below" the region. This way, the action button container
can keep its default bottom right position if possible.
This is probably not the final ideal button positioning, but should at
least be an improvement on the current overlapping behaviour.
Bug: b:406668505, b:405000218
Change-Id: I81fef47d026a24eb0c6a8eff048694d352ee2907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406815
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Elijah Hewer <hewer@chromium.org>
Commit-Queue: Michelle Chen <michellegc@google.com>
Cr-Commit-Position: refs/heads/main@{#1439785}
Generalize TabDragContext::GetInsertionIndexForDraggedBounds to handle
any mix of tabs and group headers. Inserting into a group is allowed if
and only if there are no group headers being dragged. There is no
behavior change for header drags nor for normal drags, because there
isn't yet a way to start a mixed drag session.
Bug: 406529549
Change-Id: If7b0564d32f6e6946da1b5ff913a1d26d29f9f24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405742
Reviewed-by: David Pennington <dpenning@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439783}
Removes kGlicAlwaysDetached from about flags. The flag still exists.
Bug: 402233577
Change-Id: I101f401e63a4c05ac7b285a67206dcaa028abc8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405180
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Auto-Submit: Andrea Gomez <andreaxg@google.com>
Cr-Commit-Position: refs/heads/main@{#1439782}
Persistent usage record tests have been removed from wpt tests, now
remove all logic encrypted-media helper code.
Removed from spec: https://github.com/w3c/encrypted-media/issues/480
Bug: 349649084
Change-Id: Ie01f204929389d5da2c67df9dab9ef58bb11002c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6403517
Commit-Queue: Vikram Pasupathy <vpasupathy@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439780}
Branched versions of Dawn Chromium Presubmit are checking out dawn from
main instead of the corresponding dawn branch. That builder uses the
dawn_top_of_tree gclient config, which causes HEAD to be used for the
dawn revision unless the dawn_ref property is set.
This change sets the dawn_ref property for all of chromium.dawn so that
when the branch projects are set up the dawn_ref property for all of
those builders will be set to the corresponding dawn branch. The
majority of the branched builders in that group do not use the
dawn_top_of_tree config, but the property will have no effect on those
builders.
Bug: 407114936
Change-Id: Ia86781b8b6a5ba31f1a6ca9b97098608f4d1664a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410673
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439779}
The glow animation in the standalone app currently continues until
Scanner processing has finished. If Sunfish is enabled and Scanner is
disabled, this means that the glow animation continues indefinitely.
UX has suggested that in the case Scanner is disabled, the glow
animation should continue until Sunfish OCR finishes. We don't have such
a signal yet, so for now just immediately pause the animation if Scanner
is disabled.
Bug: b:400798746
Change-Id: I8c2fa86b45d2cdd7c22c60bda5bd66aedd573589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6406988
Reviewed-by: Elijah Hewer <hewer@chromium.org>
Commit-Queue: Michelle Chen <michellegc@google.com>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439778}
This CL updates the issuer selection and dialog cancellation handling of
the SelectBnplIssuerDialog to match the Chrome Desktop UI team-approved
approach in the BnplTosDialog. Previously, the dialog could close itself
via DialogDelegate and the controller reacts to the close. Now the
controller is responsible for closing the delegate after receiving a
user-cancelled event from the dialog.
This CL also adds kombucha tests for the SelectBnplIssuerDialog, and
removes redundant browser tests.
Bug: 356443046
Change-Id: I6608d5167be3234efb9719f9fadf1819c1de2a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6397923
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Vinny Persky <vinnypersky@google.com>
Cr-Commit-Position: refs/heads/main@{#1439777}
The searchbox currently uses the same one. Use a white logo icon when
the side panel is rendering in dark mode. See bug for demo and
screenshots.
Change-Id: I6ca883aa348a4aaf71e22fbf844a68bc8eeabeab
Bug: 407039251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6410891
Reviewed-by: Ali Stanfield <stanfield@google.com>
Commit-Queue: Juan Mojica <juanmojica@google.com>
Auto-Submit: Juan Mojica <juanmojica@google.com>
Cr-Commit-Position: refs/heads/main@{#1439774}
This adds a new test suite that runs the cc_unittests with
the UiUsesLayerLists feature enabled. For now we run this
on just enough bots to get minimal coverage; eventually we
can promote this to be run everywhere a normal suite is run.
There is a filter file associated with this test suite in
//testing/buildbot/filters/layer_list_mode.cc_unittests.filter
that tracks all of the expected failures; we want this file to
eventually be empty.
Bug: 404813701
Change-Id: I1659407b4ca4bc841675b5ae6758439564610139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405714
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Gary Tong <gatong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439771}
Most log statements should be debug-only to avoid binary size bloat.
This CL turns some VLOG() into DVLOG() and removes some log statements
altogether.
Bug: 40100455
Change-Id: I1b1aaba609c12d1632341cf5a2a61a1dc808eff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6401013
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Olivia Saul <jsaul@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439770}
IPH will be trigger from PdfPageIphController.
Bug: 405813894
Change-Id: I4ffbb683a67b828966cef4ebc44fe6682106a9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6404395
Commit-Queue: Shu Yang <shuyng@google.com>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1439767}
